Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification bar #109

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Notification bar #109

merged 6 commits into from
Jun 3, 2024

Conversation

claudioantonio
Copy link
Contributor

Draft PR to mainly bring a words of caution proposal for review and alignment.
It is missing final layout adjustments and naming review.

image

@claudioantonio claudioantonio added the a-frontend Area: front-end label May 30, 2024
@claudioantonio claudioantonio added this to the Testnet 2/2 milestone May 30, 2024
@claudioantonio claudioantonio requested a review from guidanoli May 30, 2024 14:50
@claudioantonio claudioantonio self-assigned this May 30, 2024
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bug-buster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:51am

@karmentruong
Copy link

Reworded some parts and addressed some small typos - let me know what you think!

Aiming not to scare people away, but still communicate the risks involved in a clear manner:

🚨 Considerations for early adopters of Bug Buster Alpha 🚨

Bug Buster is in its alpha stage, meaning that its development is still heavily active and thus changes (new features, improvements and fixes) can come at anytime.

Regarding security, Bug Buster is built on top of the Cartesi Rollups SDK and developed with meticulous care and attention to detail. However, we cannot guarantee that the platform is entirely free of bugs or vulnerabilities at this stage.

To avoid any potential loss of funds, we recommend that you use the platform with caution and avoid using it with large amounts of funds.

Finally, this is an exciting phase of development and your feedback really matters! Together, let's build an innovative, safer and user-friendly open-source bug bounty platform for the Web3 industry 🌟

Feel free to explore, ask questions, and provide feedback on our Discord channel [link] or message us on our X account.

Copy link
Contributor

@guidanoli guidanoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please do not forget to run pnpm prettier.

frontend/src/app/header.tsx Outdated Show resolved Hide resolved
>
<Group bg="gray">
<Center w="100%">
<Anchor href="/notification" underline="never">We are in Alpha stage, read more.</Anchor>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Anchor href="/notification" underline="never">We are in Alpha stage, read more.</Anchor>
<Anchor href="/notification" underline="never">We are in alpha stage. Click here to learn more.</Anchor>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep it short and also would like to avoid repeating "learn more".
What do you think about "We are in alpha stage, click here for more info"? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. :-)

return (
<Group justify="center">
<Stack align="center" w="60%">
<Title mt="lg">🚨Words of caution to our early user adopters🚨</Title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Title mt="lg">🚨Words of caution to our early user adopters🚨</Title>
<Title mt="lg">🚨 Words of caution to our early adopters 🚨</Title>

Comment on lines 10 to 11
Bug Buster is in alpha stage and this means that its development is heavily
active thus changes (new features, improvements and fixes) can come anytime.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Bug Buster is in alpha stage and this means that its development is heavily
active thus changes (new features, improvements and fixes) can come anytime.
Bug Buster is in alpha stage, which means its development is heavily
active, and changes (such as fixes and improvements) can come at any time.

Comment on lines 14 to 16
In regards to security, althought Bug Buster is built on top of Cartesi Rollups SDK
and its development has been done with care, we cannot guarantee that the platform
is free of bugs or vulnerabilities at this stage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In regards to security, althought Bug Buster is built on top of Cartesi Rollups SDK
and its development has been done with care, we cannot guarantee that the platform
is free of bugs or vulnerabilities at this stage.
In regard to security, althought Bug Buster is built on top of Cartesi Rollups SDK
and is being maintained with great care, we cannot guarantee that the platform
is free of bugs or vulnerabilities at this stage.

is free of bugs or vulnerabilities at this stage.
</Text>
<Text>
To avoid any potential loss of funds, we recommend that you use the platform with scaution, and avoid using it with large amounts of funds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To avoid any potential loss of funds, we recommend that you use the platform with scaution, and avoid using it with large amounts of funds.
To avoid any potential loss of funds, we recommend that you use the platform with caution, and avoid depositing large amounts of funds.

Comment on lines 22 to 23
Finally, this is an exciting phase of development and your feedback really matters!
Let’s build together a innovative, safer and user-friendly open source bug bounty platform for the web3 industry? 🌟
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Finally, this is an exciting phase of development and your feedback really matters!
Let’s build together a innovative, safer and user-friendly open source bug bounty platform for the web3 industry? 🌟
Nevertheless, this is an exciting phase of development and your feedback really matters!
Let’s build together an innovative, safer, and user-friendly open source bug bounty platform for the web3 industry? 🌟

@guidanoli
Copy link
Contributor

I just saw @karmentruong provided her feedback on this as well. Feel free to mix-and-match mine with hers.

@guidanoli
Copy link
Contributor

This needs a rebase.

@claudioantonio claudioantonio marked this pull request as ready for review June 3, 2024 00:52
@claudioantonio claudioantonio requested a review from guidanoli June 3, 2024 00:52
Copy link
Contributor

@guidanoli guidanoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claudioantonio claudioantonio merged commit 32473fe into main Jun 3, 2024
2 checks passed
@claudioantonio claudioantonio deleted the notification-bar branch June 3, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-frontend Area: front-end
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants