Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a landing page #111

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Create a landing page #111

merged 2 commits into from
Jun 3, 2024

Conversation

claudioantonio
Copy link
Contributor

Closes #69

@claudioantonio claudioantonio requested a review from guidanoli June 3, 2024 03:06
@vercel Vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bug-buster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 4:21pm

@claudioantonio claudioantonio marked this pull request as ready for review June 3, 2024 03:06
guidanoli
guidanoli reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@guidanoli guidanoli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a variant="outline" prop to the "Learn More" <Button> component, so that it looks like the following. With this, you could remove the style={{ textDecoration: "none", color: "white" }} prop from the <Link> component.

image

Also, it would be good to run pnpm prettier.

frontend/src/app/page.tsx Outdated
<Link href={"/explore"}>
<Button size="lg">Explore Bounties</Button>
</Link>
<Link style={{ textDecoration: "none", color: "white"}} href={"https://github.com/crypto-bug-hunters/bugless/blob/main/README.md"}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know GitHub redirects to the current repository URL, but it's good to have it point to the correct one right off the bat.

Suggested change
<Link style={{ textDecoration: "none", color: "white"}} href={"https://github.com/crypto-bug-hunters/bugless/blob/main/README.md"}>
<Link style={{ textDecoration: "none", color: "white"}} href={"https://github.com/crypto-bug-hunters/bug-buster/blob/main/README.md"}>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing! It was a copy and past from the old PR (before renaming). Good catch!!!

@claudioantonio
Copy link
Contributor Author

I'd add a variant="outline" prop to the "Learn More" <Button> component, so that it looks like the following. With this, you could remove the style={{ textDecoration: "none", color: "white" }} prop from the <Link> component.

I simply loved!!!

@claudioantonio claudioantonio merged commit 7a1803e into main Jun 3, 2024
2 checks passed
@claudioantonio claudioantonio deleted the feature/landing-page branch June 3, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidanoli guidanoli guidanoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a landing page
2 participants
@claudioantonio @guidanoli