-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to build and push machine image to GHCR #118
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some suggestions to use specific GH actions.
If you think we don't need them now, you'd need to at least use the docker/login-action to be able to do a docker image push
in the line 56.
Huge thanks for the feedback, @endersonmaia! |
9369951
to
31d085b
Compare
- name: Build bounty examples | ||
run: make bounties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that I'm not happy with is the fact that we're building the bounty examples like this, because I'm not sure whether we'll be able to leverage the cache import/export capabilities of GitHub Actions this way...
Co-authored-by: Enderson Maia <[email protected]>
No description provided.