fix: check preconditions before running exploit code for the solidity bounty #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guidanoli
reviewed
Aug 5, 2024
guidanoli
reviewed
Aug 5, 2024
guidanoli
reviewed
Aug 5, 2024
guidanoli
reviewed
Aug 5, 2024
guidanoli
approved these changes
Aug 6, 2024
edubart
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the github repo @edubart discovered some known issues that could break the bounty. The following preconditions were added to the assertion script:
The result of the new assertion script when we submit the code that allowed Eduardo to break the bounty is presented below.
The goal is to deploy it asap while so people can continue playing with it on testnet and meanwhile redo the analysis of the solidity compiler github repo to check if there are other known issues to be added as preconditions.