Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pnpm to 9.x #130

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Bump pnpm to 9.x #130

merged 1 commit into from
Aug 12, 2024

Conversation

guidanoli
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bug-buster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 11:09am

@claudioantonio
Copy link
Contributor

Why should we upgrade pnpm before the mainnet launch? 🤔

@guidanoli
Copy link
Contributor Author

We only use pnpm for the front-end, and it's good practice to keep dependencies up-to-date.
I don't see how upgrading it would negatively impact the mainnet launch.

@claudioantonio
Copy link
Contributor

claudioantonio commented Aug 12, 2024

We only use pnpm for the front-end, and it's good practice to keep dependencies up-to-date.

I totally agree it is a good practice, that is why I created issue #15 sometime ago. We are aligned on the practice and the point here is only about timing. 😉

I don't see how upgrading it would negatively impact the mainnet launch.

If you are already using this version for sometime and everything is working well, I think we go for it. Is it the case?
Another way to move ahead would be to upgrade locally and do an overall test (all features) to check if everything goes well. It would not take too much time given we currently have a small feature set. Did you already check all feature after upgrading?

I am still using 8.15.5 so I have no idea about any impact. I will start testing Dimitar's work in a few minutes.

@guidanoli
Copy link
Contributor Author

Did you already check all feature after upgrading?

It works fine for me with pnpm 9.x

Copy link
Contributor

@claudioantonio claudioantonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given tests were successful, let's go!

@guidanoli guidanoli merged commit 4566448 into main Aug 12, 2024
2 checks passed
@guidanoli guidanoli deleted the feature/bump-pnpm branch August 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants