Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Cartesi Node image in the CI #134

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

guidanoli
Copy link
Contributor

Makes use of the new --json option of the cartesi deploy build command (added in 0.16.0).

@guidanoli guidanoli requested a review from endersonmaia August 9, 2024 14:43
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bug-buster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 9:16pm

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@claudioantonio
Copy link
Contributor

Sorry for the silly question, but let me put it: Does this PR improves the dapp's node building that is already working on our CI or does it add this possibility to build the node in our CI?

@guidanoli
Copy link
Contributor Author

Does this PR improves the dapp's node building that is already working on our CI or does it add this possibility to build the node in our CI?

The CI currently only builds the Cartesi Machine image.
This PR aims to make the CI also build the Cartesi Node image.

@guidanoli guidanoli merged commit e021f29 into main Aug 12, 2024
2 checks passed
@guidanoli guidanoli deleted the feature/build-node-image branch August 12, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants