Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voucher execution #14

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

claudioantonio
Copy link
Contributor

@claudioantonio claudioantonio commented Feb 20, 2024

This PR introduces the voucher execution feature.
It covers hackers reward and also sponsors refunding.

voucher notification only for connected users

Fixing hydration error

fix for react warnings and layout

Removing unsed import

Refactoring to move functions to proper place

Removing reference to unexisting favicon

Provide command to advance time and allow withdrawal test for sponsors

Reverting UX chnages not related to the voucher execution issue

Updating voucher notes

Presenting message when there is no vouchers
@claudioantonio claudioantonio marked this pull request as ready for review February 23, 2024 18:29
Copy link
Contributor

@guidanoli guidanoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works fine.

frontend/src/app/voucher/page.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@guidanoli guidanoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please execute npm run prettier. 😊

@fmoura
Copy link
Contributor

fmoura commented Feb 29, 2024

The Voucher UI Icon could be more explicit , or bigger. I got it quick because it was not there before.

@fmoura
Copy link
Contributor

fmoura commented Feb 29, 2024

No Feedback about the "voucher execution" transaction

@fmoura
Copy link
Contributor

fmoura commented Feb 29, 2024

Added new issues to tackle the two improvements I posted above

@guidanoli guidanoli merged commit d3e5c57 into crypto-bug-hunters:main Feb 29, 2024
@claudioantonio claudioantonio deleted the voucher-execution branch March 1, 2024 14:09
@guidanoli guidanoli linked an issue Mar 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support voucher execution
3 participants