Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on PRs #146

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Run CI on PRs #146

merged 2 commits into from
Sep 5, 2024

Conversation

guidanoli
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bug-buster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 11:59pm

@endersonmaia
Copy link
Contributor

This could avoid tagging if not going to release.

Will not solve if we want a pr- tagged container image release.

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1ecd6e2..5311aa1 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -98,6 +98,7 @@ jobs:
             jq -r '"image=\(.image)"' >> "$GITHUB_OUTPUT"
 
       - name: Create tags for Cartesi Node image
+        if: startsWith(github.ref, 'refs/tags/v')
         env:
           METADATA_JSON: ${{ steps.extract_metadata.outputs.json }}
           CARTESI_NODE_IMAGE: ${{ steps.build_node.outputs.image }}

@guidanoli
Copy link
Contributor Author

Will not solve if we want a pr- tagged container image release.

Might be nice to have those, so that people can test stuff out without having to build locally from scratch.

@guidanoli
Copy link
Contributor Author

Now, we'll also push images for PRs.

Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to sync with next branch so we can try this on PRs targeting next.

@guidanoli guidanoli changed the base branch from main to next September 5, 2024 13:49
@guidanoli guidanoli merged commit 56d8026 into next Sep 5, 2024
3 checks passed
@guidanoli guidanoli deleted the feature/run-ci-on-prs branch September 5, 2024 13:49
guidanoli added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants