Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build reproducible #148

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Conversation

endersonmaia
Copy link
Contributor

Replaces #141

endersonmaia and others added 6 commits September 5, 2024 10:54
- lock baseimage to ubuntu:noble-20240801
- avoid using apt upgrade -y
- lock version of all packages installed via apt

It's not guaranteed since apt update will bring the current state of the
remote mirror used and because of that the dependecies for the installed
packages can change between runs.
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bug-buster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 6:03pm

@endersonmaia endersonmaia mentioned this pull request Sep 6, 2024
@endersonmaia endersonmaia changed the title Feature/bump ubuntu and go versions Make build reproducible Sep 6, 2024
Copy link
Contributor

@guidanoli guidanoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@endersonmaia endersonmaia merged commit 24daede into next Sep 6, 2024
3 of 4 checks passed
@endersonmaia endersonmaia self-assigned this Sep 6, 2024
@guidanoli guidanoli deleted the feature/bump-ubuntu-and-go-versions branch September 6, 2024 19:20
@claudioantonio claudioantonio added this to the Solidity 0.8.27 milestone Sep 9, 2024
guidanoli added a commit that referenced this pull request Sep 18, 2024
* chore: bump go version to 1.23.0

* chore: bump cartesi/sdk to 0.9.0

* chore: bump Ubuntu to 24.04

* feat: attempt to make resulting image reproducible

- lock baseimage to ubuntu:noble-20240801
- avoid using apt upgrade -y
- lock version of all packages installed via apt

It's not guaranteed since apt update will bring the current state of the
remote mirror used and because of that the dependecies for the installed
packages can change between runs.

* fixup! feat: attempt to make resulting image reproducible

* fix: enhance determinism of binaries

Co-authored-by: Guilherme Dantas <[email protected]>

---------

Co-authored-by: Guilherme Dantas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants