-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make build reproducible #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lock baseimage to ubuntu:noble-20240801 - avoid using apt upgrade -y - lock version of all packages installed via apt It's not guaranteed since apt update will bring the current state of the remote mirror used and because of that the dependecies for the installed packages can change between runs.
Co-authored-by: Guilherme Dantas <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
endersonmaia
changed the title
Feature/bump ubuntu and go versions
Make build reproducible
Sep 6, 2024
guidanoli
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
guidanoli
added a commit
that referenced
this pull request
Sep 18, 2024
* chore: bump go version to 1.23.0 * chore: bump cartesi/sdk to 0.9.0 * chore: bump Ubuntu to 24.04 * feat: attempt to make resulting image reproducible - lock baseimage to ubuntu:noble-20240801 - avoid using apt upgrade -y - lock version of all packages installed via apt It's not guaranteed since apt update will bring the current state of the remote mirror used and because of that the dependecies for the installed packages can change between runs. * fixup! feat: attempt to make resulting image reproducible * fix: enhance determinism of binaries Co-authored-by: Guilherme Dantas <[email protected]> --------- Co-authored-by: Guilherme Dantas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #141