Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use block.timestamp for bounty status badge #39

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix: use block.timestamp for bounty status badge #39

merged 1 commit into from
Mar 1, 2024

Conversation

guidanoli
Copy link
Contributor

Closes #16

@guidanoli guidanoli self-assigned this Feb 29, 2024
@claudioantonio
Copy link
Contributor

Hey @guidanoli , I tried to run bugless to test the change and the dapp did not launch.
@fmoura could please try to run bugless on Gui's branch just to check if it is something in my environment?
image

@guidanoli guidanoli force-pushed the fix/use-block-timestamp-instead-of-date-now branch from 33c40ca to 249e90d Compare March 1, 2024 02:57
@guidanoli
Copy link
Contributor Author

guidanoli commented Mar 1, 2024 •
edited
Loading

Oops, you're right, @claudioantonio.
I've fixed the issue, and improved the layout of the code.
Now, the BountyStatus definition also contains the number of days left.
This makes the code for the bounty badges a lot simpler. :-)

@guidanoli guidanoli force-pushed the fix/use-block-timestamp-instead-of-date-now branch 5 times, most recently from 5b47c39 to f3cbef6 Compare March 1, 2024 12:32
claudioantonio
claudioantonio reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@claudioantonio claudioantonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @guidanoli , nice work! A minor comment is that I would move the BountyStatus union type definition to a new file in the /model folder. What do you think about it?

@guidanoli
Copy link
Contributor Author

A minor comment is that I would move the BountyStatus union type definition to a new file in the /model folder.

Yeah, I can do that. :-)

@guidanoli guidanoli force-pushed the fix/use-block-timestamp-instead-of-date-now branch from f3cbef6 to 4fee133 Compare March 1, 2024 16:25
@guidanoli guidanoli requested a review from claudioantonio March 1, 2024 16:28
@guidanoli guidanoli merged commit 2ae56db into main Mar 1, 2024
@guidanoli guidanoli deleted the fix/use-block-timestamp-instead-of-date-now branch March 1, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudioantonio claudioantonio claudioantonio approved these changes

@fmoura fmoura Awaiting requested review from fmoura

Assignees

@guidanoli guidanoli

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@guidanoli @claudioantonio