-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Sunodo SDK to 0.4.0 #81
Conversation
Running
Here is the output of
|
8f05f14
to
a2d4f88
Compare
a2d4f88
to
c2fc2a2
Compare
The tests are failing, but I'm leaving the bare minimum for a future PR to fix just the tests, and not the infrastructure around the test environment. |
c2fc2a2
to
6223006
Compare
I've created #82 for us to fix the Lua tests later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still building and testing to make a final review, but already have some comments that could be considered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting this erro when trying to send a bounty via cli.
❯ go run ./cli send bounty \
-n "Lua Bounty" \
-d "Description of Lua bounty" \
-c ./tests/bounties/lua-bounty/lua-5.4.3-bounty_riscv64.tar.xz
INF fork/exec /usr/local/bin/cast: argument list too long
exit status 1
Co-authored-by: Enderson Maia <[email protected]>
This is a known issue with the CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, I suggest this patch
diff --git a/Dockerfile b/Dockerfile
index 31efcf9..912d908 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -4,7 +4,9 @@
# cross build stage
FROM ubuntu:22.04 as build-stage
+ARG DEBIAN_FRONTEND=noninteractive
RUN <<EOF
+set -e
apt update
apt upgrade -y
apt install -y --no-install-recommends \
@@ -39,7 +41,9 @@ RUN go build -o ./dapp ./contract
# riscv64 build stage
FROM --platform=linux/riscv64 riscv64/ubuntu:22.04 as riscv64-build-stage
+ARG DEBIAN_FRONTEND=noninteractive
RUN <<EOF
+set -e
apt update
apt upgrade -y
apt install -y --no-install-recommends \
@@ -87,7 +91,13 @@ RUN <<EOF
set -e
apt-get update
apt-get upgrade -y
-apt-get install -y --no-install-recommends busybox-static ca-certificates curl xz-utils libasan8 libasan6
+apt-get install -y --no-install-recommends \
+ busybox-static \
+ ca-certificates \
+ curl \
+ libasan6 \
+ libasan8 \
+ xz-utils
curl -o ${MACHINE_EMULATOR_TOOLS_DEB} -fsSL https://github.com/cartesi/machine-emulator-tools/releases/download/v${MACHINE_EMULATOR_TOOLS_VERSION}/${MACHINE_EMULATOR_TOOLS_DEB}
dpkg -i ${MACHINE_EMULATOR_TOOLS_DEB}
rm ${MACHINE_EMULATOR_TOOLS_DEB}
Thanks a bunch, guys! 🙏 |
Closes #71