Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend containerization #94

Conversation

claudioantonio
Copy link
Contributor

Closes #49
PS1: @guidanoli there is only one comment in .eslintrc.json that I would like to keep because I added a "hack". If you create an empty project it is not needed so I would like to register why there is "next/babel" on that file, ok? But if you still don't like it, I can remove.
PS2: @endersonmaia now it can be easier if you need to make any change on the branch and update the PR. 😉

@guidanoli
Copy link
Contributor

there is only one comment in .eslintrc.json that I would like to keep because I added a "hack".

I didn't know it was a hack. Let's keep it then.

@guidanoli
Copy link
Contributor

now it can be easier if you need to make any change on the branch and update the PR. 😉

The branch is still under your repository, though.
I assume you gave @endersonmaia access to your personal repository, then?

@claudioantonio
Copy link
Contributor Author

now it can be easier if you need to make any change on the branch and update the PR. 😉

The branch is still under your repository, though. I assume you gave @endersonmaia access to your personal repository, then?

I didn't @guidanoli ... 😳 But I did now just to not close this PR also.
The next ones I will be aware to create branches from the original repo. 😉
@endersonmaia please let me know if it worked for you, ok? 🙏

Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I can build and run. With this hitting main branch, I'll get back to my PR with instructions to setup the fly.io frontend deployment.

@claudioantonio
Copy link
Contributor Author

Here we go!!!

@claudioantonio claudioantonio merged commit 4f4cf06 into crypto-bug-hunters:main May 10, 2024
@claudioantonio claudioantonio deleted the frontend-containerization branch May 10, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a frontend container image
3 participants