Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: versiondb latest version not compatible with sdk 47 #1115

Closed
wants to merge 1 commit into from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jul 28, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe force-pushed the fix_versiondb_compact branch from c4da78a to a63a814 Compare July 28, 2023 06:12
@mmsqe mmsqe marked this pull request as ready for review July 28, 2023 06:13
@mmsqe mmsqe requested a review from a team as a code owner July 28, 2023 06:13
@mmsqe mmsqe requested review from yihuang and JayT106 and removed request for a team July 28, 2023 06:13
fmt.Println("end version not specified, default to latest version,", endVersion)
} else {
endVersion = latestVersion + 1
fmt.Println("end version not specified, default to latest version + 1,", endVersion)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain the root cause for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize mem store issue, could close this pr now

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1115 (a63a814) into main (d7d9101) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   46.19%   46.17%   -0.03%     
==========================================
  Files          82       82              
  Lines        7386     7396      +10     
==========================================
+ Hits         3412     3415       +3     
- Misses       3612     3620       +8     
+ Partials      362      361       -1     
Files Changed Coverage Δ
versiondb/client/dump.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@mmsqe mmsqe closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants