chore: perf improvement

[kewde]

This PR avoids calling publicKeyConvert because they are really slow using a pure BN.js implementation.

[kewde]

cc @RyanZim

[RyanZim]

I'm wondering if these assertions should be combined with the conditional here:

hdkey/lib/hdkey.js

Lines 49 to 50 in 62c25cc

	assert(value.length === 33 || value.length === 65, 'Public key must be 33 or 65 bytes.')
	assert(secp256k1.publicKeyVerify(value) === true, 'Invalid public key')

[kewde]

@RyanZim I was wondering the same, but I assume someone out there might be relying on the error messages, and changing the behavior might be considered a breaking change?

publicKeyConvert also verifies the public key internally, so we technically omit publicKeyVerify calls for uncompressed keys.

[RyanZim]

Ah, true; good point about the error messages.

[RyanZim]

utACK