Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Appeal key" #65

Closed
irenegia opened this issue Jul 12, 2022 · 8 comments
Closed

"Appeal key" #65

irenegia opened this issue Jul 12, 2022 · 8 comments
Assignees

Comments

@irenegia
Copy link
Collaborator

We want to allow others to be able to create appeal for a deal created by the client X.

We decided that we can implement this by modifying the "create proposal" function.
In the new version the client can specify another address (different form the default that is the client address) that can send an on-chain message to create an appeal.

@0xjona
Copy link
Collaborator

0xjona commented Jul 12, 2022

The appeal key is one, the client sets it while creating the deal.
It is your own address by default, and it can be changed in #64 to be the address of for example a smart contract that includes multiple addresses aka appeal keys

@0xjona
Copy link
Collaborator

0xjona commented Jul 12, 2022

A variation to this would be having an admin key see #66, which doesn’t affect the idea of the appeal key

@0xjona
Copy link
Collaborator

0xjona commented Jul 12, 2022

@turinglabsorg should we call this keys or addresses? And what’s the difference in your opinion?

@turinglabsorg
Copy link
Collaborator

@0xjona for me it's an appeal address, addresses are hashed version of keys. They're comparable but not exactly the same. In any case it's an address allowed to make transactions.

@nicola
Copy link

nicola commented Jul 13, 2022

Ok to call it a appeal address.

The appeal addresses should be a list of keys and it should contain all keys that the client picks at deal creation. We don't have to force the deal creator key to be in the appeal address. Imagine preparers that resell this product to other people which do not want to include themselves.

@turinglabsorg
Copy link
Collaborator

So it's a list? In our first iteration we said it should be just one address, it's pretty the same for me, just need to understand if it's an array of addresses or a single address. We must be sure there's at least one appeal address or not?

turinglabsorg added a commit that referenced this issue Jul 14, 2022
@turinglabsorg
Copy link
Collaborator

ok, @nicola, created as list inside the contract and made tests to be sure everything works at protocol level. @0xjona we can close it.

@turinglabsorg turinglabsorg moved this from ToDo to Implementation in retriev.org Jul 14, 2022
@irenegia
Copy link
Collaborator Author

(hackMD updated)

@turinglabsorg turinglabsorg moved this from Implementation to Validation in retriev.org Jul 15, 2022
@turinglabsorg turinglabsorg moved this from Validation to Done in retriev.org Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants