Compiler: turn proc pointer into proc literal in some cases #9824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
asterite
force-pushed
the
compiler/turn-proc-pointer-into-proc-literal
branch
from
b807d13 to
22e9a25
Compare
bcardiff
reviewed
Oct 23, 2020
| else | ||
| call_self = @last | ||
| end | ||
| call_self = @last |
There was a problem hiding this comment.
Why is the "If obj is a primitive like ..." no longer needed?
There was a problem hiding this comment.
Because if obj is a Var thenh this was turned into a ProcLiteral, so a proc pointer at this point never has a Var as its obj.
| if proc_pointer = arg.proc_pointer | ||
| case proc_pointer.obj | ||
| when Var | ||
| arg.raise "#{message} (closured vars: #{proc_pointer.obj})" |
There was a problem hiding this comment.
This condition seems new. The previous var.join ", " was moved a couple of lines below. Is there a spec missing to stress this error?
There was a problem hiding this comment.
Without this, existing specs would fail. So there are already specs covering this. I just had to adjust the logic for the new behavior.
bcardiff
approved these changes
Oct 23, 2020
This was referenced Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8584
This essentially makes the compiler transform this:
To this:
The effect is the same: it captures the value at the point of creating the proc/closure. However, the compiler has already logic for closuring
tmpso it remains in the heap.