Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish tooltip bug fix #58

Merged
merged 1 commit into from
Apr 30, 2024
Merged

finish tooltip bug fix #58

merged 1 commit into from
Apr 30, 2024

Conversation

realmichaeltao
Copy link

@realmichaeltao realmichaeltao commented Apr 27, 2024

Pivotal Tracker Link

What this PR does:

This pull request addresses a bug related to tooltip persistence upon clicking checkboxes. Previously, tooltips remained visible even after clicking a checkbox. The solution involves triggering a redraw of the table with $tables.draw() upon a checkbox change. Additionally, during each table redraw, all tooltips are first disposed of and then reinitialized. This ensures that tooltips only appear when needed and do not persist inappropriately.

Include screenshots, videos, etc.

Before:
Screenshot 2024-04-25 at 17 23 50
After:
Screenshot 2024-04-25 at 17 23 55

Who authored this PR?

@perryzjc
@realmichaeltao

How should this PR be tested?

  • Is there a deploy we can view?
    Yes
  • What do the specs/features test?
    Since this change primarily affects frontend functionality, traditional backend testing frameworks like Cucumber or RSpec are not applicable here.
  • Are there edge cases to watch out for?
    Check tooltip behavior when multiple checkboxes are interacted with in quick succession.

Are there any complications to deploying this?

No

Checklist:

  • Has this been deployed to a staging environment or reviewed by a customer?
  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

@ArushC
Copy link

ArushC commented Apr 30, 2024

Looks good👍

@ArushC ArushC merged commit 19dc0d8 into main Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants