-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add authprovider owncloudsql #2119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
reviewed
Sep 30, 2021
refs
previously approved these changes
Sep 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the tests!
A few remarks:
- if the use of queries becomes more prominent we should consider using a query builder
butonic
force-pushed
the
authprovider-owncloudsql
branch
2 times, most recently
from
October 1, 2021 11:05
e9f8355
to
14faf86
Compare
C0rby
previously approved these changes
Oct 1, 2021
@butonic can you add a line to the CODEOWNERS to also track this plugin? |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
authprovider-owncloudsql
branch
from
November 1, 2021 09:08
14faf86
to
2fb3efc
Compare
@labkode @ishank011 rebased, added CODEOWNERS line, good to merge |
labkode
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an authprovider that can be configured to authenticate against an owncloud classic mysql database. It verifies the password from the oc_users table. I am using this for my personal migration / parralel setup.
Tested using sqlite and in production using this toml file for reva:
Then running grpcurl like this:
I am only using this to test basic auth for some routes that the ocis proxy forwards to reva ... but I'd like to forward auth requests to the gateway, and then I could directly authenticate without having to go throug an ldap proxy.