Reduce redundant stat calls when statting by resource ID #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishank011
force-pushed
the
reduce-redundant-stat-calls
branch
from
745348a to
a4bd025
Compare
labkode
previously approved these changes
Oct 26, 2021
ishank011
force-pushed
the
reduce-redundant-stat-calls
branch
from
65aebc8 to
ec038fd
Compare
labkode
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were making multiple redundant stat calls, especially when looking up resources by ID.
For example, in the gateway, we'd call
getPathwhich would stat the ID, and then after performing a few checks on the returned path, call stat again; similarly in EOS FS.This PR brings down the number of such calls from 4 to 1 (for EOS fs) and for the other file systems, by at least a factor of half.
This is a start towards such performance improvements, I'll keep on working on these.