-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quicklinks #2715
Merged
Merged
Quicklinks #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
kobergj
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
April 5, 2022 14:26
C0rby
suggested changes
Apr 5, 2022
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go
Outdated
Show resolved
Hide resolved
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go
Outdated
Show resolved
Hide resolved
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
Quicklinks
branch
2 times, most recently
from
April 6, 2022 14:20
f47cc99
to
bfc12f7
Compare
Signed-off-by: jkoberg <[email protected]>
C0rby
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
9 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces quicklinks.
Creating a Link with the flag
"quicklink=true"
will create a Quicklink. If another create link request with "quicklink=true" comes in, the server will return the existing link instead of creating a new one."true"
usual go convertible string values are supported for the quicklink flag:1, t, T, TRUE, true, True
see https://golang.google.cn/pkg/strconv/#ParseBoolCurl example: