-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Pass remote share id and shared secret in OCM call #3852
Conversation
…other side somehow
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Let's call it ProviderID and then add it here as well:
|
In reva/internal/http/services/ocmd/shares.go Line 155 in d1eacc5
|
And also in ocm.ReceivedShare
|
As discussed in the Zoom call now, @gmgigi96 will update this PR so that is uses |
@michielbdejong @glpatcern I have pushed my changes, can you review? |
I have opened cs3org/cs3apis#209 for the needed changes in the CS3APIs |
@gmgigi96 cs3org/cs3apis#209 is merged so you can revert 7e55510 right? |
This reverts commit c466de2.
Co-authored-by: Gianmaria Del Monte <[email protected]>
Co-authored-by: Gianmaria Del Monte <[email protected]>
In
internal/grpc/services/ocmshareprovider/ocmshareprovider.go
, passshare.Token
asSharedSecret
inside the WebDAV protocol details, and use the remote id as the resource id.This PR also adds some debug messages.