Add a geospatial extension #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A UML diagram depicting the relationships between the different types in the example.
A key point is that bmi_geo_heat "has a" bmi_heat, and the relationship only goes one way, with the extension being able to access the core BMI but not the other way around. |
|
My Fortran is rusty, so I welcome any suggestions for improvement to the code in this PR. |
This matchesthe change in 77407c8. [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request explores how a BMI extension could work in Fortran. It's modeled on @mcflugen's csdms/bmi-example-python#31, with some differences based on the language and the choices I made.
Like the Fortran specification for the core BMI functions, the geospatial BMI extension resides in a separate repository: https://github.com/mdpiper/bmi-geospatial-fortran. The code there defines an abstract type, bmi_geo, that is intended to be overridden by a concrete type in an implementation.
This PR implements bmi_geo through the type bmi_geo_heat. A key feature of a bmi_geo_heat type is that it has a reference to the bmi_heat type that implements the core BMI functions for the heat model.
I included an example program, bmi_geospatial_ex, that demostrates how to call both the core BMI functions and the extension functions for the heat model.