error handling

[ctaggart]

Do we wish to use a structured Error type like surf 2 moved to?
https://github.com/http-rs/surf/releases/tag/v2.0.0
https://blog.yoshuawuyts.com/async-http/#error-handling

[ctaggart]

Currently just using:

pub type Error = Box<dyn std::error::Error + Send + Sync>;
pub type Result<T> = std::result::Result<T, Error>;
 
   Ok(res.json().await?)

In some use cases, it would be good to add more context, like the full response. Here I was using anyhow crate to achieve that.

    let res = client.execute(req).await?;
    match res.error_for_status_ref() {
        Ok(_) => Ok(res.json().await?),
        Err(err) => {
            let e = Error::new(err);
            let e = e.context(res.text().await?);
            Err(e)
        }
    }

[ctaggart]

Planned implementation is listed in Azure/azure-sdk-for-rust#47

[ctaggart]

fixed by #63