This repository has been archived by the owner on Jun 3, 2019. It is now read-only.
Next => feature/apollo #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update broken feature/flow link in docs
* Updated CSP for nonce backwards compatibility * Documented * Updates comments
- `SERVER_PORT` to `PORT` - `SERVER_HOST` to `HOST` - `CLIENT_DEVSERVER_PORT` to `CLIENT_DEV_PORT` - Replaces `code-split-component` with `react-async-component` - Renames the `nodeBundlesIncludeNodeModuleFileTypes` config property to `nodeExternalsFileTypeWhitelist` - Refactors the server and serviceworker offline page generation. We now use a set of React components (`ServerHTML` and `HTML`) to manage our HTML in a uniform fashion. - Refactors how we resolve environment specific configuration values. `NODE_ENV` is reserved for specifying a `development` or `production` build now. Use `CONF_ENV` to specify a target environment if you would like to resolve an environment specific .env file. - Refactors the client configuration filter rule to be contained within the main configuration and moves the configuration object creation into the server middleware. - Renames the `safeGetConfig` to `config`, and made it a default export. - Removes the `cross-env` library. - All server/client/shared code all use the shared config helper. - Updated dependencies, including to the latest Webpack official 2 release. - New babel plugins to optimise React production build performance. - Adds new icon sets. - Chrome favicon request issue. - Cleans up the package scripts. - Service worker would fail if a subfolder was added to the public folder.
…sary. Everything internal (tooling/docs) has been moved to an "internal" folder. The rest lives at root. The configuration has been given a massive once over too. I really disliked how there were multiple ways the config values were being read throughout the project. Everything has been changed now to use a config helper that lives in the '<projectroot>/config/' folder. All things config lives in that folder now too.
Removes CONF_ENV and refactors environment variable resolution to use NODE_ENV again.
|
Booyah! Thanks bro! I'll review this in the next few days. |
|
Sorry, those next few days have gone by and am swamped still. Feel confident you have done a great job here though. Lets wait for |
|
Hey @ctrlplusb ! How does the job going ? :) When can we expect to see this PR merged? Cant wait to get the update ! You're doing an awesome job ;) |
|
This will need some work to merge. I'll pull down the Redux branch and fix it up this afternoon. |
|
Checkout my latest PR. It’s in good shape.
…On July 11, 2017 at 9:28:56 PM, Dion Dirza ***@***.******@***.***)) wrote:
@strues(https://github.com/strues) any progress so far?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub(#367 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AF7kZX08X_kclw0mZo7n0cHSVfprcDLyks5sND14gaJpZM4MIABb).
|
|
Closing this in favor of #469 which is essentially finished. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings feature/apollo up to date with the next branch.