This repository has been archived by the owner on Jun 3, 2019. It is now read-only.
postcss/sass update #468
Merged
postcss/sass update #468
+5,354
−4,259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update broken feature/flow link in docs
* Updated CSP for nonce backwards compatibility * Documented * Updates comments
- `SERVER_PORT` to `PORT` - `SERVER_HOST` to `HOST` - `CLIENT_DEVSERVER_PORT` to `CLIENT_DEV_PORT` - Replaces `code-split-component` with `react-async-component` - Renames the `nodeBundlesIncludeNodeModuleFileTypes` config property to `nodeExternalsFileTypeWhitelist` - Refactors the server and serviceworker offline page generation. We now use a set of React components (`ServerHTML` and `HTML`) to manage our HTML in a uniform fashion. - Refactors how we resolve environment specific configuration values. `NODE_ENV` is reserved for specifying a `development` or `production` build now. Use `CONF_ENV` to specify a target environment if you would like to resolve an environment specific .env file. - Refactors the client configuration filter rule to be contained within the main configuration and moves the configuration object creation into the server middleware. - Renames the `safeGetConfig` to `config`, and made it a default export. - Removes the `cross-env` library. - All server/client/shared code all use the shared config helper. - Updated dependencies, including to the latest Webpack official 2 release. - New babel plugins to optimise React production build performance. - Adds new icon sets. - Chrome favicon request issue. - Cleans up the package scripts. - Service worker would fail if a subfolder was added to the public folder.
…sary. Everything internal (tooling/docs) has been moved to an "internal" folder. The rest lives at root. The configuration has been given a massive once over too. I really disliked how there were multiple ways the config values were being read throughout the project. Everything has been changed now to use a config helper that lives in the '<projectroot>/config/' folder. All things config lives in that folder now too.
Removes CONF_ENV and refactors environment variable resolution to use NODE_ENV again.
fix the "collectCoverageFrom" config of jest
* Update dependecies, change component prop-types. * Helmet now has prop-types support. * Update yarn lockfile * Bumped react-router and forgot prop types in clientconfig. * Bump enzyme and prop-types * Bump react-async-component and enzyme
* Fix lint * code split naming strategy sample * remove HTTP protocol to be more flexible * Refactor polyfill.io Due to counter route become broken in mobile device, use only default feature instead * Fix lint while prettier revert changes * update deps
* update eslintrc line-breaks for windows
* add prop-types as a dependency to prevent react-hot-loader from breaking build.
add cross-env for starting tasks which break on Windows.
add FAQ for when running develop and javascript files aren't loading even though the build is successful.
modify the clean task to execute a function rather than use the ${npm bin} exec command, which doesnst work on Windows.
* save exact package.json
* add cross-env to npm scripts
dev server host always 0.0.0.0, not host config
Passing colors from server to console in develop.
|
Hey guys, do you know why github is getting old messages from the past? This is a new PR and it seems to be a weird behavior. Anyway, can somebody look into my pr? Thanks! |
|
@sergiokopplin I'll check it out right now. Don't think I've experienced receiving old github messages, but I wouldn't be shocked 😄 |
|
thanks @strues |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.