-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new event icons #133
Add new event icons #133
Conversation
We could also add small circular holes in each 15 puzzle tile to make that icon stand out more |
@jfly thoughts on these? |
@jfly kind ping :) |
Yeah, certainly from my side at some point, I'm just juggling a lot. I do like all of these, but I think the Megaminx and Square-1 BLD icons would make more sense if the puzzle part wasfacing the other way (so that the blindfold isn't on the puzzle), what do you think? |
Here‘s a perspective of an unrelated third person and user of the other existing svg icons: I do like the proposed icons as they are right now. For me the event is easy to identify and with the current puzzle orientation, in my view more aesthetic. |
(Sorry for the silence here) I agree with @lgarron about the orientation of the megaminx and sq1 bld icons. Otherwise, this LGTM! |
I think this way makes more sense, because that's how the non-bld icons are positioned. The other way would make it seem like the icons are "out of frame". |
I think the Squan BLD and Mega BLD icons are good. Although I am not quite sure about the 15 puzzle, I think isn't obvious enough where you can immediately tell what it is. |
I also considered adding little circular holes in the middle of each 15 puzzle tile (because I think using actual numbers wouldn't be good for an icon). What do you think about that option? |
Yeah, either way is unprecedented: either something is "out of frame" or we have things overlapping, neither of which we've done before. If you prefer this, I'm fine with that. @dmint789, if you'd like to get this merged up ASAP, I suggest removing the 15 puzzle from this PR, and you and @MPGsebkli27 can discuss this in a separate PR. (In general, it would be best to submit each new unrelated icon as a separate PR). |
@jfly okay, that's probably a good idea. Or at least the same type of icon (i.e. something like 4x4 OH and 5x5 OH is probably fine to submit at the same time). I'll remove 15 puzzle. |
@jfly removed it now. Should be ready to merge. |
Sorry for the delay. Looks like CI is failing, and not your fault. Looking into this now. |
@dmint789, v2.0.2 is released and it includes these new icons: https://www.npmjs.com/package/@cubing/icons/v/2.0.2 |
@jfly thank you! |
This PR adds the following event icons:
Magic One-Handed
2-man 2-7 Relay
Megaminx Blindfolded
Square-1 Blindfolded
Siamese Cube
Previews:
This one is shown side-by-side with the 3bld icon, because there may be some concern of them being too similar at small scales. Another possible option is to show the entire Megaminx face except the three pieces shown here, but then it would have to be scaled down too much.