Fix make lint and make format, enforce biome check in Nix/CI
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `make` commands were broken because we didn't have `biome` listed as a dependency, and we didn't have a `biome.json` file. There's unfortunately still some inconsistency here in that `nix fmt` and `nix flake check` are going to use whatever version of biome is present in `nixpkgs`, whereas `make lint` is going to use the version in our `package-lock.json`. We could make this consistent, but I'm inclined to wait for it to be a problem.
|
Thanks LGTM! The JS changes look like appropriate fixes without semantic changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
makecommands were broken because we didn't havebiomelisted asa dependency, and we didn't have a
biome.jsonfile.There's unfortunately still some inconsistency here in that
nix fmtand
nix flake checkare going to use whatever version of biome ispresent in
nixpkgs, whereasmake lintis going to use the version inour
package-lock.json. We could make this consistent, but I'minclined to wait for it to be a problem.