Update dev instructions so they can be copied for plain bun
#140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfly, I just realized I can't use the copy button on the dev instructions. Are you alright with this fix? |
jfly
reviewed
Jan 3, 2025
README.md
Outdated
|
|
||
| ```shell | ||
| git clone https://github.com/cubing/icons && cd icons | ||
| nix develop # Optional. See above. | ||
| nix develop |
There was a problem hiding this comment.
I'd rather not treat nix too specially here. People need to get bun installed somehow. They can DIY it, or they can use the nix dev shell.
Can we just remove the nix develop line from the original example? Then you can copy paste without issue.
There was a problem hiding this comment.
Alright, lemme know if you like e2ee40a !
…ain `bun` and with `nix`.
lgarron
force-pushed
the
lgarron/copyable-plain-bun
branch
from
321c8a0 to
546af64
Compare
lgarron
force-pushed
the
lgarron/copyable-plain-bun
branch
from
546af64 to
e2ee40a
Compare
jfly
approved these changes
Jan 3, 2025
lgarron
changed the title
bun and with nix.bun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.