-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.1.0 #143
v2.1.0 #143
Conversation
package.json
Outdated
@@ -29,7 +29,10 @@ | |||
"url": "https://github.com/cubing/icons.git/issues" | |||
}, | |||
"description": "Cubing Icons and Fonts", | |||
"files": ["dist", "ts"], | |||
"files": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfly: This is the fight between Biome and npm version
I mentioned. I think Biome's formatting is better, but npm
is the canonical tool for package publication. Not sure what the best option is here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I'm happy with:
- Ignoring
package.json
- OR: adding a postversion that formats package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'll stick with ignoring.
postversion
might be a good start, but there are various reasons tools might rewrite package.json
and I don't have a full list anywhere.
316e0e1
to
7419206
Compare
Release plan: git switch release-v2.1.0
git rebase main
git checkout main
git merge --ff-only release-v2.1.0
# Using: https://github.com/lgarron/dotfiles/blob/b71bea0c5d3a8c310f67145329f807eb2a8d417b/scripts/git/tagpush.ts
tagpush
make publish |
This is a pre-release for #143 to test end-to-end ecosystem compatibility.
This is a pre-release for #143 to test end-to-end ecosystem compatibility.
This is a pre-release for #143 to test end-to-end ecosystem compatibility.
Release notes: - Overhaul the build system. The usage is still the same and icon sizing and layout should be compatible, but: - Fonts are no longer inlined into the CSS, allowing for loading of the most efficient format available. - Exports are now specifed by the package: - `@cubing/icons/css`: the new recommended entry point for CSS. - `@cubing/icons/ts`: data about available icons in TypeScript.
7419206
to
f4162d7
Compare
Okay, I shook out a few things in the pre-releases and https://cdn.cubing.net/v0/css/@cubing/icons/css is now working well. |
80b2dbc
to
f4162d7
Compare
This is a pre-release for #143 to test end-to-end ecosystem compatibility.
@jfly, you good with releasing? (There's a merge conflict, but it just needs a rebase once we know what version we're bumping from.) |
uber nit: Can we stick to the documented release process? |
Unfortunately, I actually really disagree with that process, as it:
That said, I would definitely really like to have a re-think of this once we introduce |
From talking to @jfly, I'm actually going to bump this to
A full version bump at least avoids anyone who's relying on semantic version to avoid implicit behaviour. |
Published as |
Agreed. Let's discuss over in cubing/actions-workflows#3 |
Release notes:
@cubing/icons/css
: the new recommended entry point for CSS.@cubing/icons/ts
: data about available icons in TypeScript.