Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a @cubing/icons/js entry point, transpiled via tsc #147

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

lgarron
Copy link
Member

@lgarron lgarron commented Jan 23, 2025

For a discussion of tradeoffs, see: #146

@lgarron lgarron requested a review from jfly January 23, 2025 19:39
@lgarron lgarron changed the title Add a @cubing/icons/js entry point, transpiled via TypeScript. Add a @cubing/icons/js entry point, transpiled via tsc Jan 23, 2025
Copy link
Member

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not a blocking comment, just a thought: is there some sort of "end to end" testing we could/should be doing to detect issues like this before our users are affected?

@lgarron
Copy link
Member Author

lgarron commented Jan 24, 2025

Not a blocking comment, just a thought: is there some sort of "end to end" testing we could/should be doing to detect issues like this before our users are affected?

I've tried to do some of this in the past, and I'm currently on the side of "this isn't worth the maintenance tradeoff". There are a lot of caveats and complications due to ecosystem "quirks".

In any case, there was no regression here, this PR isn't so much a bug as an enhancement. Since it's using raw tsc and uses both exports and legacy path-based index files, it should be as cross-compatible as possible.

A "not quite end-to-end" test to run the built output might be worthwhile, lemme know if you wanna talk through some options.

@lgarron lgarron merged commit 321f612 into main Jan 24, 2025
2 checks passed
@lgarron lgarron deleted the lgarron/transpile branch January 24, 2025 19:10
@jfly
Copy link
Member

jfly commented Jan 25, 2025

In any case, there was no regression here, this PR isn't so much a bug as an enhancement.

Maybe I'm confused about what we're doing here. Didn't the 3.0 release of cubing icons break things for @dmint789? If so, that's a regression.

@lgarron
Copy link
Member Author

lgarron commented Jan 25, 2025

In any case, there was no regression here, this PR isn't so much a bug as an enhancement.

Maybe I'm confused about what we're doing here. Didn't the 3.0 release of cubing icons break things for @dmint789? If so, that's a regression.

Ah, nah. @cubing/icons/ts was a new entry point in v3.0.0. I was hoping it would be enough to address #119 for @dmint789, but it wasn't enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants