Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

mouseWheel:true prevent other mouse handlers to catch events #980

Closed
alvarotrigo opened this issue Oct 9, 2015 · 9 comments
Closed

mouseWheel:true prevent other mouse handlers to catch events #980

alvarotrigo opened this issue Oct 9, 2015 · 9 comments
Assignees

Comments

@alvarotrigo
Copy link

It seems that when I use the option mouseWheel :true my other mouse wheel handlers won't receive any event.

My event being fired

My event not being fired

@sculove
Copy link
Collaborator

sculove commented Mar 28, 2016

iscroll is preventing on wheel event.

_wheel: function (e) {
        if ( !this.enabled ) {
            return;
        }

        e.preventDefault();
        e.stopPropagation();

I will check it.

@sculove sculove self-assigned this Mar 28, 2016
sculove added a commit that referenced this issue Mar 29, 2016
@sculove
Copy link
Collaborator

sculove commented Mar 29, 2016

I fix it on master branch. please wait for next release.

@alvarotrigo
Copy link
Author

Thanks @sculove, hopefully this will allow iScroll.js to finally be used in fullpage.js.

@sculove sculove closed this as completed Mar 29, 2016
@alvarotrigo
Copy link
Author

Why did you close it? Will it be merged?

@sculove
Copy link
Collaborator

sculove commented Mar 29, 2016

@alvarotrigo yes. I merged

sculove added a commit that referenced this issue Mar 29, 2016
@alvarotrigo
Copy link
Author

Great! Thanks!

@alvarotrigo
Copy link
Author

This problem doesn't seem to be solved for IE. (any version)
Can we re-open it?

@alvarotrigo
Copy link
Author

e.preventDefault(); should be also removed.
Not quite sure why is there or if it will break anything, but removing it makes it work.

@alvarotrigo
Copy link
Author

I would like to add iScroll.js as a dependency for fullPage.js but I won't be able to do it until this issue gets fixed.

Meanwhile I'll be forced to provide a forked version of iScroll.js and therefore I won't be able to add the official iScroll.js as a dependency in neither bower or npm.
Neither would I be able to link to the official iScroll.js for people to download it.

aisouard pushed a commit to Mappy/iscroll that referenced this issue Feb 22, 2017
aisouard pushed a commit to Mappy/iscroll that referenced this issue Feb 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants