This repository has been archived by the owner on May 28, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 125
Add 'path' to output of parser #213
Comments
@aslakhellesoy ping |
@aslakhellesoy Whoa! Issue closed? Can you at least comment on what I wrote? |
Hi @Zearin. The entire repo has moved, and I didn't want to move over all open issues. Did you see the comment in ae7c92f? What you're asking for is actually supported in the latest release. You have the |
A feature's location is the line and column number where it appears in a document. The document itself would have a path location, sure. Something like Edit: Ninja'd by Aslak |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Problem
I want to call
parse()
and be able to access the path to the*.feature
file that was parsed.Recommendation
Add
path
toGherkinDocument.feature.location
(i.e., the output ofparse()
).Rationale
Currently, the parser output has a
location
for just about everything it contains. However, theselocation
fields only haveline
andcolumn
.Since a feature represents a physical file, it seems odd that there is no way to access the
path
from the result of aparse()
.Also, the
compile()
function needs afeature
and apath
. If you pass a filename toparse()
, thencompile()
should be able to grab the path from the result.If the parser received a string instead of a filename, then
GherkinDocument.feature.location
could simply be set tonull
/nil
/None
.The text was updated successfully, but these errors were encountered: