Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with multiple versions of Cucumber #729

Closed
mvz opened this issue Aug 21, 2020 · 3 comments · Fixed by #811
Closed

Test with multiple versions of Cucumber #729

mvz opened this issue Aug 21, 2020 · 3 comments · Fixed by #811
Milestone

Comments

@mvz
Copy link
Contributor

mvz commented Aug 21, 2020

Summary

Add some mechanism to test that Aruba still works with older versions of Cucumber that are officially supported.

Expected Behavior

At least the combination of Aruba with Cucumber 2.4 is tested on TravisCI.

Current Behavior

Tests are run with the latest Cucumber version supported on each Ruby version. This means versions older than Cucumber 4 are not tested.

Possible Solution

Use the appraisal gem to test with different combinations of dependencies.

Context & Motivation

I'd like to start using more modern ways of defining the steps, and also improve step wording, but I'm afraid I'll break support for older Cucumber versions.

@mvz mvz added this to the 1.1.0 milestone Aug 22, 2020
@mvz
Copy link
Contributor Author

mvz commented Jan 3, 2021

The upcoming end of support for Ruby 2.5 may be a good time to increase the minimum versions of Aruba's dependencies. This should mitigate this problem as well.

@mvz
Copy link
Contributor Author

mvz commented Apr 14, 2021

Adding Appraisals may also help in testing with upcoming Cucumber releases. See #801.

@aurelien-reeves
Copy link
Contributor

Short summary of the discussion we had in #801:

We keep dependency to cucumber bounded to the actual version of cucumber.

That is source of issues when working on releasing new versions of cucumber. We had a really hard time releasing cucumber version 6 because of circular dependencies: cucumber depends on cucumber-wire which depends on aruba which depends on cucumber.

It has been suggested to remove the upper-bound dependency version. That way, releasing new version of cucumber would be easier.

It has also been suggested to have some tests for aruba using cucumber's master branch.

This is still an open discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants