Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer versions of Cucumber #801

Merged
merged 5 commits into from
Apr 14, 2021
Merged

Allow newer versions of Cucumber #801

merged 5 commits into from
Apr 14, 2021

Conversation

mattwynne
Copy link
Member

@mattwynne mattwynne commented Apr 12, 2021

This allows us to test / release new versions of Cucumber without first having to come here to make a new release of Arubua.

I think the only reason to cap the max version would be if we knew there was a backwards-compatibility problem with a release of Cucumber, but there isn't, so I think we can safely just remove it?

This allows us to test / release new versions of Cucumber without
first having to come here to make a new release of Arubua.

I think the only reason to cap the max version would be if we knew there
was a backwards-compatibility problem with a release of Cucumber, but
there isn't, so let's remove it?
@mattwynne mattwynne requested a review from mvz April 12, 2021 15:07
@aurelien-reeves aurelien-reeves added dependencies Pull requests that update a dependency file status: needs review labels Apr 14, 2021
@mvz
Copy link
Contributor

mvz commented Apr 14, 2021

I'm not a big fan of open-ended dependencies: If Cucumber releases a new major version, it may break Aruba. On the other hand, since Cucumber uses Aruba for its own tests, that is not very likely at the moment.

What would be other possible ways to solve the problem?

@aurelien-reeves
Copy link
Contributor

aurelien-reeves commented Apr 14, 2021

I'm not a big fan of open-ended dependencies: If Cucumber releases a new major version, it may break Aruba. On the other hand, since Cucumber uses Aruba for its own tests, that is not very likely at the moment.

What would be other possible ways to solve the problem?

Actually, at the moment, we cannot release a new version of cucumber because of aruba.
We could, but we cannot execute tests before releasing it.

I share the thinking of @mattwynne: while everything is working fine, having an open-ended dependency is not an issue.
If some day cucumber breaks aruba, we can release a patched version of aruba to restrict the usage of some specific version of cucumber, then work on a minor or major new release to fix the issue we would face with that new cucumber.

What do you think?

@mvz
Copy link
Contributor

mvz commented Apr 14, 2021

while everything is working fine, having an open-ended dependency is not an issue.

Of course. I have an issue with the case where not everything is fine 🙂. Maybe I can bump the max version to "< 7.0" and perhaps even test with cucumber's master branch?

@aurelien-reeves
Copy link
Contributor

while everything is working fine, having an open-ended dependency is not an issue.

Of course. I have an issue with the case where not everything is fine 🙂. Maybe I can bump the max version to "< 7.0" and perhaps even test with cucumber's master branch?

Bumping to version < 7.0 would actually result in the exact same risk, but less future-proof:

Cucumber version 6.0 actually does not exists yet. Maybe aruba is not compatible with it, we just don't know yet, and we won't until cucumber@6 is released.

Having some tests which uses cucumber's master branch would help us to detect issues before any releases.

@mvz mvz merged commit 7d2ed27 into master Apr 14, 2021
@mvz mvz deleted the allow-new-cucumbers branch April 14, 2021 13:04
@aurelien-reeves
Copy link
Contributor

In order to be able to move-on with our actual release of cucumber-wire and cucumber, we have decided to keep an upper-bound version number here and to continue the discussion there: #729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file status: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants