-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow newer versions of Cucumber #801
Conversation
This allows us to test / release new versions of Cucumber without first having to come here to make a new release of Arubua. I think the only reason to cap the max version would be if we knew there was a backwards-compatibility problem with a release of Cucumber, but there isn't, so let's remove it?
I'm not a big fan of open-ended dependencies: If Cucumber releases a new major version, it may break Aruba. On the other hand, since Cucumber uses Aruba for its own tests, that is not very likely at the moment. What would be other possible ways to solve the problem? |
[skip ci]
Actually, at the moment, we cannot release a new version of cucumber because of aruba. I share the thinking of @mattwynne: while everything is working fine, having an open-ended dependency is not an issue. What do you think? |
Of course. I have an issue with the case where not everything is fine 🙂. Maybe I can bump the max version to "< 7.0" and perhaps even test with cucumber's master branch? |
Bumping to version < 7.0 would actually result in the exact same risk, but less future-proof: Cucumber version 6.0 actually does not exists yet. Maybe aruba is not compatible with it, we just don't know yet, and we won't until cucumber@6 is released. Having some tests which uses cucumber's master branch would help us to detect issues before any releases. |
In order to be able to move-on with our actual release of cucumber-wire and cucumber, we have decided to keep an upper-bound version number here and to continue the discussion there: #729 |
This allows us to test / release new versions of Cucumber without first having to come here to make a new release of Arubua.
I think the only reason to cap the max version would be if we knew there was a backwards-compatibility problem with a release of Cucumber, but there isn't, so I think we can safely just remove it?