Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some rubocop offenses #537

Merged
merged 9 commits into from
Feb 4, 2018
Merged

Fix some rubocop offenses #537

merged 9 commits into from
Feb 4, 2018

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Feb 4, 2018

Summary

Fix some rubocop offenses

Details

Mostly autocorrects by RuboCop, activated by removing some of the items from .rubocop_todo.yml.

Motivation and Context

Continuous improvement of the code uniformity and quality.

How Has This Been Tested?

Travis.

Types of changes

  • Refactoring (cleanup of codebase withouth changing any existing functionality)

olleolleolle
olleolleolle approved these changes Feb 4, 2018
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the long road.

@mvz mvz merged commit adb9b9c into master Feb 4, 2018
@mvz mvz deleted the fix-some-rubocop-offenses branch February 4, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @olleolleolle