Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress keyward argument warnings in Ruby 2.7 #672

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

koic
Copy link
Member

@koic koic commented Sep 14, 2019

This PR suppresses the following keyward argument warnings when using Ruby 2.7.

% ruby -v
ruby 2.7.0dev (2019-09-12T15:35:29Z master 69acf40b45) [x86_64-darwin17]
% bundle exec rake

(snip)

/Users/koic/src/github.com/cucumber/aruba/lib/aruba/platforms/unix_platform.rb:116:
warning: The last argument is used as the keyword parameter
/Users/koic/.rbenv/versions/2.7.0-dev/lib/ruby/2.7.0/fileutils.rb:605:
warning: for `rm_r' defined here
/Users/koic/src/github.com/cucumber/aruba/lib/aruba/platforms/unix_platform.rb:135:
warning: The last argument is used as the keywo
rd parameter
/Users/koic/.rbenv/versions/2.7.0-dev/lib/ruby/2.7.0/fileutils.rb:1120:
warning: for `touch' defined here
./Users/koic/src/github.com/cucumber/aruba/lib/aruba/platforms/unix_platform.rb:150:
warning: The last argument is used as the keyword parameter
/Users/koic/.rbenv/versions/2.7.0-dev/lib/ruby/2.7.0/fileutils.rb:1012:
warning: for `chmod_R' defined here

cf. https://bugs.ruby-lang.org/issues/14183

This PR suppresses the following keyward argument warnings
when using Ruby 2.7.

```console
% ruby -v
ruby 2.7.0dev (2019-09-12T15:35:29Z master 69acf40b45) [x86_64-darwin17]
% bundle exec rake

(snip)

/Users/koic/src/github.com/cucumber/aruba/lib/aruba/platforms/unix_platform.rb:116:
warning: The last argument is used as the keyword parameter
/Users/koic/.rbenv/versions/2.7.0-dev/lib/ruby/2.7.0/fileutils.rb:605:
warning: for `rm_r' defined here
/Users/koic/src/github.com/cucumber/aruba/lib/aruba/platforms/unix_platform.rb:135:
warning: The last argument is used as the keywo
rd parameter
/Users/koic/.rbenv/versions/2.7.0-dev/lib/ruby/2.7.0/fileutils.rb:1120:
warning: for `touch' defined here
./Users/koic/src/github.com/cucumber/aruba/lib/aruba/platforms/unix_platform.rb:150:
warning: The last argument is used as the keyword parameter
/Users/koic/.rbenv/versions/2.7.0-dev/lib/ruby/2.7.0/fileutils.rb:1012:
warning: for `chmod_R' defined here
```

cf. https://bugs.ruby-lang.org/issues/14183
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent.

Copy link
Member

@amatsuda amatsuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mvz
Copy link
Contributor

mvz commented Sep 14, 2019

Nice!

@mvz mvz merged commit b48ea34 into cucumber:master Sep 14, 2019
@koic koic deleted the suppress_ruby27_warning branch September 14, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants