Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on process launcher to set child process environment #891

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jan 20, 2023

Summary

Depend on process launcher to set child process environment

Details

This change removes a needless #with_environment call when spawning a process. Setting the local environment at this point no effect since we already set the environment by configuring the child process launcher.

Motivation and Context

Cleaning up a needless complication in preparation for switching to Process.spawn.

How Has This Been Tested?

Specs and cukes were run and there was no regression.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Setting the local environment during process launch has no effect since
we set the environment by configuring the child process launcher.
@mvz mvz merged commit d3049ec into main Jan 20, 2023
@mvz mvz deleted the set-environment-once branch January 20, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant