Depend on process launcher to set child process environment #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depend on process launcher to set child process environment
Details
This change removes a needless
#with_environment
call when spawning a process. Setting the local environment at this point no effect since we already set the environment by configuring the child process launcher.Motivation and Context
Cleaning up a needless complication in preparation for switching to
Process.spawn
.How Has This Been Tested?
Specs and cukes were run and there was no regression.
Types of changes
Checklist: