Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cucumber-expressions: Use Unicode symbols as a parameter boundary in snippets #1108

Merged
merged 3 commits into from
Jul 10, 2020
Merged

cucumber-expressions: Use Unicode symbols as a parameter boundary in snippets #1108

merged 3 commits into from
Jul 10, 2020

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jul 9, 2020 •
edited
Loading

Numerical parameters should be bounded by whitespace, punctuation or symbols
on both sides.

$1.50 -> ${double}
15° Celsius -> {int}° Celcius
i18n -> i18n
$15m -> $15m

Fixes: #844

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

@mpkorstanje
cucumber-expressions: Use Unicode symbols as a parameter boundary
744de67 
Numerical parameters should be bounded by whitespace, punctuation or symbols
on both sides.

```
$1.50 -> ${double}
15° Celsius -> {int}° Celcius
i18n -> i18n
$15m -> $15m
```
Fixes: #844
@mpkorstanje mpkorstanje force-pushed the cucumber-expressions-fix-844-number-groups-only-need-white-space-on-one-side branch from 0453d93 to 744de67 Compare July 9, 2020 14:12
@mpkorstanje mpkorstanje changed the title cucumber-expressions: Suggest numbers when parameter has text on one side cucumber-expressions: Use Unicode symbols as a parameter boundary Jul 9, 2020
@mpkorstanje mpkorstanje changed the title cucumber-expressions: Use Unicode symbols as a parameter boundary cucumber-expressions: Use Unicode symbols as a parameter boundary in snippets Jul 9, 2020
@mpkorstanje mpkorstanje marked this pull request as ready for review July 9, 2020 15:34
@mpkorstanje mpkorstanje merged commit 35cdfbe into master Jul 10, 2020
@mpkorstanje mpkorstanje deleted the cucumber-expressions-fix-844-number-groups-only-need-white-space-on-one-side branch July 10, 2020 06:02
@mpkorstanje mpkorstanje mentioned this pull request Jul 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snippet generator - don't enforce whitespace rule for numerical parameters
1 participant
@mpkorstanje