-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gherkin java codegen #1959
Merged
Merged
Gherkin java codegen #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
reviewed
Apr 20, 2022
gherkin/java/src/main/groovy/io/cucumber/gherkin/GherkinDialects.gsp
Outdated
Show resolved
Hide resolved
mpkorstanje
reviewed
Apr 20, 2022
gherkin/java/src/main/java/io/cucumber/gherkin/GherkinDialectProvider.java
Outdated
Show resolved
Hide resolved
mpkorstanje
reviewed
Apr 20, 2022
gherkin/java/src/main/java/io/cucumber/gherkin/GherkinDialectProvider.java
Outdated
Show resolved
Hide resolved
mpkorstanje
reviewed
Apr 20, 2022
mpkorstanje
reviewed
Apr 20, 2022
mpkorstanje
reviewed
Apr 20, 2022
gherkin/java/src/main/groovy/io/cucumber/gherkin/GherkinDialects.gsp
Outdated
Show resolved
Hide resolved
Thanks for the feedback @mpkorstanje - fixed now I think. Good to merge? |
mpkorstanje
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The one nit pick aside.
gherkin/java/src/main/java/io/cucumber/gherkin/GherkinDialectProvider.java
Outdated
Show resolved
Hide resolved
Cheers btw. |
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generate GherkinDialects.java at build time, using Groovy as a template engine and the root
gherkin-languages.json
as data for the template. This fixes #1957.Details
With this change the library no longer needs to parse JSON at runtime. This makes the library:
With this change there is no need to copy the
gherkin-languages.json
file either.Motivation and Context
See #1957
Types of changes
Checklist: