cucumber-expressions: add go implementation #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent work @charlierudolph!! Could you port #346 into this PR please? Then I'll merge it to master and also set up a read-only subrepo, and CI. I'm on holiday and will be back in a week or so. |
|
I've merged to master and set up a read-only subrepo mirror at https://github.com/cucumber/cucumber-expressions-go. The Travis build is OK, except for Go 1.7: https://travis-ci.org/cucumber/cucumber-expressions-go/builds/362455501 I can't think of a good reason to support Go 1.7, so I'll just remove that requirement. Exciting stuff indeed! |
aslakhellesoy
added a commit
that referenced
this pull request
Apr 5, 2018
aslakhellesoy
added a commit
that referenced
this pull request
Apr 8, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a go implementation for cucumber-expressions.
Details
Looked at the java / javascript / ruby implementations and ported to go.
Motivation and Context
I want this for building the shared binary and so the go version of cucumber can use them in the mean time
How Has This Been Tested?
I ported over all the tests from the javascript implementation (and some from other implementations that weren't in the javascript implementation). I'll try and make them consistent in another PR.
Types of changes
Checklist: