-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cucumber-expressions to generate the match in fake-cucumber #793
Merged
aslakhellesoy
merged 67 commits into
master
from
fake-cucumber-use-cucumber-expressions
Nov 22, 2019
Merged
Changes from 1 commit
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
a8fae4f
fake-cucumber: Reorganize stepDefinitions handling
vincent-psarga b6dfe41
Use CucumberExpressions to generate the correct match
vincent-psarga 1e7fb19
Reorganize Makefile as fake-cucumber now relies on cucumber-expressions
vincent-psarga 4a5820f
Add default step "I have {int} cukes in my belly"
vincent-psarga 9eb54bb
Move cucumber-expressions at the beginning of the dependencies
vincent-psarga 3bcb972
fake-cucumber: WIP add StepDefinitionRegistry
vincent-psarga 0f87a27
Add SupportCodeExecutor
aslakhellesoy 96b707e
Fix broke test
aslakhellesoy 18b1ee9
Formatting
aslakhellesoy 3e88a88
Add failing test for next coding session
aslakhellesoy 948ceac
Merge master
aslakhellesoy aded1b6
Do not return the SupportCodeExecutor result directly but compute sta…
vincent-psarga fc5baa8
First naive implementation for StepDefinition.toMessage()
vincent-psarga 1cf9bca
fake-cucumber: StepDefinitionRegistry bubbles up error thrown by Supp…
vincent-psarga 7c448ad
Add method 'toMessages' to StepDefinitionRegistry
vincent-psarga 4371788
fake-cucumber: stream StepDefinitionDefinitions for StepDefinitionReg…
vincent-psarga 767c665
fake-cucumber: use StepDefinitionRegistry to produce TestStep messages
vincent-psarga ce20c6e
Refactor/reformat
aslakhellesoy 1807b65
Refactor
aslakhellesoy ee9ef80
Decouple IPickleStep from registry
aslakhellesoy 0b8402e
Refactor
aslakhellesoy 075fb38
Refactor
aslakhellesoy 8d48bae
fake-cucumber: add TestStep class which handles the execution and tra…
vincent-psarga cd5a33c
fake-cucumber: move tests to a better place
vincent-psarga c1d0b36
fake-cucumber: use step definitions to generate the results
vincent-psarga b0e13d8
Formatting
aslakhellesoy c14200a
Remove dead code
aslakhellesoy 3309255
Run tslint --fix on all TypeScript code as part of build
aslakhellesoy b92cb1d
Merge tslint branch, fix broken test in cucumber-query
aslakhellesoy ab628e9
Introduce Notifier for execution
aslakhellesoy 79aee62
Let TestCase emit messages about test execution
vincent-psarga 88ae120
Do not emit the TestCase message during execution but before
vincent-psarga ba74485
json-formatter: Add some debugging informations
vincent-psarga c619855
fake-cucumber: TestSTep should produce a Duration too
vincent-psarga c4a89ee
Make attempt a parameter
aslakhellesoy e29ab9e
Extract helpers
aslakhellesoy f9827d0
Add TestPlan
aslakhellesoy 388276e
Renames
aslakhellesoy 2e90268
Separate formatting from logic
aslakhellesoy 2677180
Refactor
aslakhellesoy 6a5bdf8
New CLI
aslakhellesoy 6445747
Diagram for data flow
aslakhellesoy 5746c39
Replace FakeTestResultsStream with CucumberStream
aslakhellesoy 0559180
Use CucumberStream
aslakhellesoy aa13bca
Persist cucumber-expressions
aslakhellesoy 1137f78
Fix merge conflict
aslakhellesoy e6bdeee
Bind encodeDelimited
aslakhellesoy 7e932e9
Add parameters
aslakhellesoy d57441f
Start work on Json Step Definitions
aslakhellesoy b5b03e0
Add a Circle dependency
aslakhellesoy 028bcf7
Document Cucumber Query API
aslakhellesoy 8bc026e
Document (fake) Cucumber data flow
aslakhellesoy fd30da5
Docs
aslakhellesoy dc89c34
Delete JSON step defs - they will move to a new module
aslakhellesoy fea8472
Hide id field
aslakhellesoy b1c56ac
Fix circle config
aslakhellesoy 8d39ea3
Add .NET to cucumber-query API
aslakhellesoy f0eb239
Sync proto files
aslakhellesoy 7671479
Add extra dummy expressions
vincent-psarga 16e0a9c
Field rename
aslakhellesoy 3cfcf3c
Regenerate go file
aslakhellesoy 6f08950
Add integrity check
aslakhellesoy b10b0c4
Merge branch 'fake-cucumber-use-cucumber-expressions' of github.com:c…
aslakhellesoy 5e5b7b9
Merge branch 'master' into fake-cucumber-use-cucumber-expressions
aslakhellesoy efe4d13
Reformat code
aslakhellesoy dfa019b
Merge branch 'master' into fake-cucumber-use-cucumber-expressions
aslakhellesoy 0f43b81
Update changelog
aslakhellesoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency order is now wrong because cucumber-query’s tests depends on fake-cucumber.
Better to move cucumber-expressions up and leave fake-cucumber where it was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, and the formatters also depend on this library. I fix that in the next commit.