Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle spaces in the absolute path (#1845) #1847

Merged
merged 11 commits into from
Dec 15, 2021
Merged

handle spaces in the absolute path (#1845) #1847

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6b763a3
put quotes around the absolute path (#1845)
eoola Nov 19, 2021
e40e94d
fix indentations in feature file
eoola Dec 3, 2021
406d059
Merge branch 'main' into fix-spaces-dev-path-again
eoola Dec 3, 2021
45df108
fixed the bug but needs unit testing
eoola Dec 3, 2021
4ded0b6
fixed linting
eoola Dec 3, 2021
af7212a
adds unit testing for handling paths with quotes
eoola Dec 10, 2021
b76bb70
Merge branch 'main' into fix-spaces-dev-path-again
eoola Dec 10, 2021
c3862ef
adds the fix to option splitter files
eoola Dec 10, 2021
c9974e7
Merge branch 'main' into fix-spaces-dev-path-again
aslakhellesoy Dec 13, 2021
65ba09d
updated changelog and removed wip tag
eoola Dec 14, 2021
ba71328
Merge branch 'fix-spaces-dev-path-again' of github.com:cucumber/cucum…
eoola Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions features/formatter_paths.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ Feature: Formatter Paths
Background:
Given a file named "features/a.feature" with:
"""
Feature: some feature
Scenario: some scenario
Given a passing step
Feature: some feature
eoola marked this conversation as resolved.
Show resolved Hide resolved
Scenario: some scenario
Given a passing step
"""
And a file named "features/step_definitions/cucumber_steps.js" with:
"""
const {Given} = require('@cucumber/cucumber')
const {Given} = require('@cucumber/cucumber')

Given(/^a passing step$/, function() {})
Given(/^a passing step$/, function() {})
"""

Scenario: Relative path
Expand All @@ -23,9 +23,10 @@ Feature: Formatter Paths
<duration-stat>
"""

@wip
eoola marked this conversation as resolved.
Show resolved Hide resolved
Scenario: Absolute path
Given "{{{tmpDir}}}" is an absolute path
When I run cucumber-js with `-f summary:{{{tmpDir}}}/summary.txt`
When I run cucumber-js with `-f summary:"{{{tmpDir}}}/summary.txt"`
Then the file "{{{tmpDir}}}/summary.txt" has the text:
"""
1 scenario (1 passed)
Expand Down