Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook types and test run ids #2463

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Add hook types and test run ids #2463

merged 6 commits into from
Jan 7, 2025

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jan 7, 2025

🤔 What's changed?

Implements some of the new messages fields from cucumber/messages#102, specifically:

  • Hook.type
  • TestRunStarted.id
  • TestCase.testRunStartedId
  • TestRunFinished.testRunStartedId

At the same time, updates all @cucumber dependencies.

Fixes #2462 and #2457.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Jan 7, 2025

Coverage Status

coverage: 97.732% (+0.002%) from 97.73%
when pulling 09400ea on hook-types
into 711d902 on main.

@davidjgoss davidjgoss marked this pull request as ready for review January 7, 2025 23:32
@davidjgoss davidjgoss merged commit 8e574d3 into main Jan 7, 2025
10 checks passed
@davidjgoss davidjgoss deleted the hook-types branch January 7, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send @cucumber/messages.HookType to formatters on the "hook" event
2 participants