Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure registry with configurer from objectFactory #1518

Closed
wants to merge 1 commit into from

Conversation

bojanv55
Copy link

Summary

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@bojanv55
Copy link
Author

Related to this. Does look a bit ugly but seems working. Otherwise needs much more refactoring because of circular dependencies...

@mpkorstanje
Copy link
Contributor

Nice! I'm afraid I can't accept this without the refactoring though. You can break the cyclic dependency by moving the object factory and its related classes to the core module. Have a look at the way I did this for v5:

https://github.com/cucumber/cucumber-jvm/blob/develop-v5/core/src/main/java/io/cucumber/core/runtime/BackendServiceLoader.java

But if it is too much effort you can also of course wait for v5. :)

@mpkorstanje
Copy link
Contributor

I think it's better to revisit this in v5.

@mpkorstanje mpkorstanje closed this Mar 8, 2019
@lock
Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants