Merge branch 'twalpole-frozen_literal'

cucumber · Jul 1, 2016 · 3d64273 · 3d64273
2 parents 9308e3a + 59e2388
commit 3d64273
Show file tree

Hide file tree

Showing 65 changed files with 69 additions and 4 deletions.
diff --git a/lib/cucumber/core.rb b/lib/cucumber/core.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/event_bus'
 require 'cucumber/core/gherkin/parser'
 require 'cucumber/core/gherkin/document'

diff --git a/lib/cucumber/core/ast.rb b/lib/cucumber/core/ast.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/comment'
 require 'cucumber/core/ast/tag'
 require 'cucumber/core/ast/feature'

diff --git a/lib/cucumber/core/ast/background.rb b/lib/cucumber/core/ast/background.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/names'
 require 'cucumber/core/ast/location'
 require 'cucumber/core/ast/describes_itself'

diff --git a/lib/cucumber/core/ast/comment.rb b/lib/cucumber/core/ast/comment.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/location'
 
 module Cucumber

diff --git a/lib/cucumber/core/ast/data_table.rb b/lib/cucumber/core/ast/data_table.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/describes_itself'
 require 'cucumber/core/ast/location'
 

diff --git a/lib/cucumber/core/ast/describes_itself.rb b/lib/cucumber/core/ast/describes_itself.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
     module Ast

diff --git a/lib/cucumber/core/ast/doc_string.rb b/lib/cucumber/core/ast/doc_string.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/describes_itself'
 require 'delegate'
 module Cucumber

diff --git a/lib/cucumber/core/ast/empty_background.rb b/lib/cucumber/core/ast/empty_background.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
     module Ast

diff --git a/lib/cucumber/core/ast/empty_multiline_argument.rb b/lib/cucumber/core/ast/empty_multiline_argument.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
     module Ast

diff --git a/lib/cucumber/core/ast/examples_table.rb b/lib/cucumber/core/ast/examples_table.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/describes_itself'
 require 'cucumber/core/ast/location'
 require 'cucumber/core/ast/names'

diff --git a/lib/cucumber/core/ast/feature.rb b/lib/cucumber/core/ast/feature.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/describes_itself'
 require 'cucumber/core/ast/names'
 require 'cucumber/core/ast/location'

diff --git a/lib/cucumber/core/ast/location.rb b/lib/cucumber/core/ast/location.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'forwardable'
 require 'cucumber/core/platform'
 module Cucumber

diff --git a/lib/cucumber/core/ast/names.rb b/lib/cucumber/core/ast/names.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
     module Ast

diff --git a/lib/cucumber/core/ast/outline_step.rb b/lib/cucumber/core/ast/outline_step.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/location'
 require 'cucumber/core/ast/describes_itself'
 require 'cucumber/core/ast/step'

diff --git a/lib/cucumber/core/ast/scenario.rb b/lib/cucumber/core/ast/scenario.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/describes_itself'
 require 'cucumber/core/ast/names'
 require 'cucumber/core/ast/empty_background'

diff --git a/lib/cucumber/core/ast/scenario_outline.rb b/lib/cucumber/core/ast/scenario_outline.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/names'
 require 'cucumber/core/ast/location'
 require 'cucumber/core/ast/describes_itself'

diff --git a/lib/cucumber/core/ast/step.rb b/lib/cucumber/core/ast/step.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/describes_itself'
 require 'cucumber/core/ast/location'
 

diff --git a/lib/cucumber/core/ast/tag.rb b/lib/cucumber/core/ast/tag.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
     module Ast

diff --git a/lib/cucumber/core/compiler.rb b/lib/cucumber/core/compiler.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/case'
 require 'cucumber/core/test/step'
 

diff --git a/lib/cucumber/core/filter.rb b/lib/cucumber/core/filter.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
 

diff --git a/lib/cucumber/core/gherkin/ast_builder.rb b/lib/cucumber/core/gherkin/ast_builder.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast'
 require 'cucumber/core/platform'
 

diff --git a/lib/cucumber/core/gherkin/document.rb b/lib/cucumber/core/gherkin/document.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 module Cucumber
   module Core

diff --git a/lib/cucumber/core/gherkin/parser.rb b/lib/cucumber/core/gherkin/parser.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'gherkin/parser'
 require 'gherkin/token_scanner'
 require 'gherkin/errors'

diff --git a/lib/cucumber/core/gherkin/tag_expression.rb b/lib/cucumber/core/gherkin/tag_expression.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
 module Core
 module Gherkin

diff --git a/lib/cucumber/core/gherkin/writer.rb b/lib/cucumber/core/gherkin/writer.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/gherkin/writer/helpers'
 require 'cucumber/core/gherkin/document'
 

diff --git a/lib/cucumber/core/gherkin/writer/helpers.rb b/lib/cucumber/core/gherkin/writer/helpers.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
     module Gherkin

diff --git a/lib/cucumber/core/platform.rb b/lib/cucumber/core/platform.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Detect the platform we're running on so we can tweak behaviour
 # in various places.
 require 'rbconfig'

diff --git a/lib/cucumber/core/report/summary.rb b/lib/cucumber/core/report/summary.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
     module Report

diff --git a/lib/cucumber/core/test/action.rb b/lib/cucumber/core/test/action.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/result'
 require 'cucumber/core/test/timer'
 require 'cucumber/core/test/result'

diff --git a/lib/cucumber/core/test/around_hook.rb b/lib/cucumber/core/test/around_hook.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
     module Test

diff --git a/lib/cucumber/core/test/case.rb b/lib/cucumber/core/test/case.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/result'
 require 'cucumber/core/gherkin/tag_expression'
 require 'cucumber/core/ast/location'

diff --git a/lib/cucumber/core/test/filters.rb b/lib/cucumber/core/test/filters.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/filters/locations_filter'
 require 'cucumber/core/test/filters/name_filter'
 require 'cucumber/core/test/filters/tag_filter'
diff --git a/lib/cucumber/core/test/filters/locations_filter.rb b/lib/cucumber/core/test/filters/locations_filter.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/filter'
 
 module Cucumber

diff --git a/lib/cucumber/core/test/filters/name_filter.rb b/lib/cucumber/core/test/filters/name_filter.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/filter'
 
 module Cucumber

diff --git a/lib/cucumber/core/test/filters/tag_filter.rb b/lib/cucumber/core/test/filters/tag_filter.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/filter'
 
 module Cucumber

diff --git a/lib/cucumber/core/test/result.rb b/lib/cucumber/core/test/result.rb
@@ -1,4 +1,5 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
 module Cucumber
   module Core

diff --git a/lib/cucumber/core/test/runner.rb b/lib/cucumber/core/test/runner.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/timer'
 
 module Cucumber

diff --git a/lib/cucumber/core/test/step.rb b/lib/cucumber/core/test/step.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/result'
 require 'cucumber/core/test/action'
 

diff --git a/lib/cucumber/core/test/timer.rb b/lib/cucumber/core/test/timer.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/result'
 
 module Cucumber

diff --git a/lib/cucumber/core/version.rb b/lib/cucumber/core/version.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Core
     class Version

diff --git a/spec/capture_warnings.rb b/spec/capture_warnings.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # With thanks to @myronmarston
 # https://github.com/vcr/vcr/blob/master/spec/capture_warnings.rb
 
@@ -22,7 +23,7 @@ def report_warnings(&block)
     end
 
     if project_warnings.any?
-      puts "#{ project_warnings.count } cucumber-core warnings detected" 
+      puts "#{ project_warnings.count } cucumber-core warnings detected"
       print_warnings('cucumber-core', project_warnings)
       fail "Please remove all cucumber-core warnings."
     end
@@ -34,7 +35,7 @@ def capture_error(&block)
     old_stderr = STDERR.clone
     pipe_r, pipe_w = IO.pipe
     pipe_r.sync    = true
-    error         = ""
+    error         = String.new
     reader = Thread.new do
       begin
         loop do

diff --git a/spec/coverage.rb b/spec/coverage.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'simplecov'
 formatters = [ SimpleCov::Formatter::HTMLFormatter ]
 

diff --git a/spec/cucumber/core/ast/background_spec.rb b/spec/cucumber/core/ast/background_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/background'
 module Cucumber::Core::Ast
   describe Background do

diff --git a/spec/cucumber/core/ast/data_table_spec.rb b/spec/cucumber/core/ast/data_table_spec.rb
@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'cucumber/core/ast/data_table'
 
 module Cucumber

diff --git a/spec/cucumber/core/ast/doc_string_spec.rb b/spec/cucumber/core/ast/doc_string_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/location'
 require 'cucumber/core/ast/doc_string'
 require 'unindent'
@@ -68,7 +69,7 @@ module Ast
         end
 
         context 'quacking like a String' do
-          let(:content) { 'content' }
+          let(:content) { String.new('content') }
           let(:content_type) { 'text/plain' }
 
           it 'delegates #encoding to the content string' do

diff --git a/spec/cucumber/core/ast/empty_multiline_argument_spec.rb b/spec/cucumber/core/ast/empty_multiline_argument_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/location'
 require 'cucumber/core/ast/empty_multiline_argument'
 

diff --git a/spec/cucumber/core/ast/examples_table_spec.rb b/spec/cucumber/core/ast/examples_table_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/examples_table'
 
 module Cucumber::Core::Ast

diff --git a/spec/cucumber/core/ast/location_spec.rb b/spec/cucumber/core/ast/location_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/location'
 
 module Cucumber::Core::Ast

diff --git a/spec/cucumber/core/ast/outline_step_spec.rb b/spec/cucumber/core/ast/outline_step_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/outline_step'
 require 'cucumber/core/ast/examples_table'
 require 'cucumber/core/ast/data_table'

diff --git a/spec/cucumber/core/ast/step_spec.rb b/spec/cucumber/core/ast/step_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/ast/step'
 require 'cucumber/core/ast/outline_step'
 require 'cucumber/core/ast/empty_multiline_argument'

diff --git a/spec/cucumber/core/compiler_spec.rb b/spec/cucumber/core/compiler_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core'
 require 'cucumber/core/compiler'
 require 'cucumber/core/gherkin/writer'

diff --git a/spec/cucumber/core/filter_spec.rb b/spec/cucumber/core/filter_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/gherkin/writer'
 require 'cucumber/core'
 require 'cucumber/core/filter'

diff --git a/spec/cucumber/core/gherkin/parser_spec.rb b/spec/cucumber/core/gherkin/parser_spec.rb
@@ -1,4 +1,5 @@
 # -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 require 'cucumber/core/gherkin/parser'
 require 'cucumber/core/gherkin/writer'
 

diff --git a/spec/cucumber/core/gherkin/writer_spec.rb b/spec/cucumber/core/gherkin/writer_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/gherkin/writer'
 require 'unindent'
 

diff --git a/spec/cucumber/core/test/action_spec.rb b/spec/cucumber/core/test/action_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/action'
 require 'cucumber/core/test/duration_matcher'
 

diff --git a/spec/cucumber/core/test/case_spec.rb b/spec/cucumber/core/test/case_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # -*- coding: utf-8 -*-
 require 'cucumber/core'
 require 'cucumber/core/gherkin/writer'

diff --git a/spec/cucumber/core/test/duration_matcher.rb b/spec/cucumber/core/test/duration_matcher.rb
@@ -1,4 +1,5 @@
 # -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 require 'cucumber/core/test/result'
 require 'rspec/expectations'
 
@@ -12,7 +13,7 @@ module Cucumber::Core::Test
 
   RSpec::Matchers.define :an_unknown_duration do
     match do |actual|
-      actual.tap { raise "#tap block was executed, not an UnknownDuration" } 
+      actual.tap { raise "#tap block was executed, not an UnknownDuration" }
       expect(actual).to respond_to(:nanoseconds)
     end
   end

diff --git a/spec/cucumber/core/test/filters/locations_filter_spec.rb b/spec/cucumber/core/test/filters/locations_filter_spec.rb
@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'cucumber/core/gherkin/writer'
 require 'cucumber/core'
 require 'cucumber/core/test/filters/locations_filter'

diff --git a/spec/cucumber/core/test/result_spec.rb b/spec/cucumber/core/test/result_spec.rb
@@ -1,4 +1,5 @@
 # -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 require 'cucumber/core/test/result'
 require 'cucumber/core/test/duration_matcher'
 

diff --git a/spec/cucumber/core/test/runner_spec.rb b/spec/cucumber/core/test/runner_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/runner'
 require 'cucumber/core/test/case'
 require 'cucumber/core/test/step'

diff --git a/spec/cucumber/core/test/step_spec.rb b/spec/cucumber/core/test/step_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/step'
 
 module Cucumber::Core::Test

diff --git a/spec/cucumber/core/test/timer_spec.rb b/spec/cucumber/core/test/timer_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core/test/timer'
 require 'cucumber/core/test/duration_matcher'
 

diff --git a/spec/cucumber/core_spec.rb b/spec/cucumber/core_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'report_api_spy'
 require 'cucumber/core'
 require 'cucumber/core/filter'

diff --git a/spec/readme_spec.rb b/spec/readme_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'stringio'
 require 'kramdown'
 

diff --git a/spec/report_api_spy.rb b/spec/report_api_spy.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class ReportAPISpy
   def initialize
     @result = []