Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use monotonic time #101

Closed
mikz opened this issue Dec 31, 2015 · 7 comments · Fixed by #103
Closed

Use monotonic time #101

mikz opened this issue Dec 31, 2015 · 7 comments · Fixed by #103

Comments

@mikz
Copy link

mikz commented Dec 31, 2015

See ruby-concurrency/concurrent-ruby#256 for reasons why.

I got bitten by this because our app uses timecop to mock with time. Namely it uses scale to make time 1000 times faster.

If you'd be interested, I could make a patch to fix it in https://github.com/cucumber/cucumber-ruby-core/blob/0807c9ca6be06777be75d13a1b769f97ef993399/lib/cucumber/core/test/timer.rb

@mattwynne
Copy link
Member

Thanks, a patch would be great.

On Thu, 31 Dec 2015 at 14:34, Michal Cichra [email protected]
wrote:

See ruby-concurrency/concurrent-ruby#256
ruby-concurrency/concurrent-ruby#256 for
reasons why.

I got bitten by this because our app uses timecop to mock with time.
Namely it uses scale to make time 1000 times faster.

If you'd be interested, I could make a patch to fix it in
https://github.com/cucumber/cucumber-ruby-core/blob/0807c9ca6be06777be75d13a1b769f97ef993399/lib/cucumber/core/test/timer.rb


Reply to this email directly or view it on GitHub
#101.

mikz pushed a commit to mikz/cucumber-ruby-core that referenced this issue Jan 5, 2016
@mikz
Copy link
Author

mikz commented Jan 5, 2016

@mattwynne great! done cce8a1d. what do you think?

@mattwynne
Copy link
Member

Looks good, thanks!

@mattwynne
Copy link
Member

I'm confused where that commit lives! Could you put into a PR for me please and help this scatterbrained over-busy project maintainer? 🙏

@mikz
Copy link
Author

mikz commented Jan 18, 2016

@mattwynne done! See #103

@mattwynne
Copy link
Member

Thanks @mikz!

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants