-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use monotonic time #101
Comments
Thanks, a patch would be great. On Thu, 31 Dec 2015 at 14:34, Michal Cichra [email protected]
|
for reasons described in ruby-concurrency/concurrent-ruby#256 closes cucumber#101
@mattwynne great! done cce8a1d. what do you think? |
Looks good, thanks! |
I'm confused where that commit lives! Could you put into a PR for me please and help this scatterbrained over-busy project maintainer? 🙏 |
@mattwynne done! See #103 |
Thanks @mikz! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
See ruby-concurrency/concurrent-ruby#256 for reasons why.
I got bitten by this because our app uses timecop to mock with time. Namely it uses scale to make time 1000 times faster.
If you'd be interested, I could make a patch to fix it in https://github.com/cucumber/cucumber-ruby-core/blob/0807c9ca6be06777be75d13a1b769f97ef993399/lib/cucumber/core/test/timer.rb
The text was updated successfully, but these errors were encountered: