Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AST classes more explicitly value objects #85

Closed
mattwynne opened this issue Apr 1, 2015 · 7 comments
Closed

Make AST classes more explicitly value objects #85

mattwynne opened this issue Apr 1, 2015 · 7 comments
Labels
⌛ stale Will soon be closed by stalebot unless there is activity

Comments

@mattwynne
Copy link
Member

Criteria:

  1. immutable
  2. equality comparison works (by location?)

See 2e85fcb#commitcomment-10458359

@mattwynne
Copy link
Member Author

See also #84

@brasmusson
Copy link
Contributor

this attr_accessor in background.rb should be possible to change to a attr_reader (the attributes are set in the constructor). What about this attr_accessor in doc_string.rb is the file attribute ever used? It is not set in the constructor, and I can remove the line from the file without neither the cucumber-ruby-core test nor the cucumber test fails.

@mattwynne
Copy link
Member Author

@brasmusson if you can remove it without breaking tests, I'm happy to rip it out.

@brasmusson
Copy link
Contributor

All attr_accessor declarations are removed from the ast classes (044cca8)

@stale
Copy link

stale bot commented Nov 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Nov 8, 2017
@stale
Copy link

stale bot commented Nov 15, 2017

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this as completed Nov 15, 2017
@lock
Copy link

lock bot commented Nov 15, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⌛ stale Will soon be closed by stalebot unless there is activity
Projects
None yet
Development

No branches or pull requests

2 participants