Background.feature is always nil

[brasmusson]

As @e2 noted (cucumber/gherkin#334), the ast class for Background has an attr_accessor for :feature, but since the #feature is never set on the background object, #feature is always nil. Therefore things like background.feature.name in for instance #before_background in formatter will not work.

[e2]

Thanks!

[mattwynne]

In general, we've tried to keep the AST in the core from having circular references. Parent nodes know about their children, but not the other way around.

I think the right fix here is to make a change in or around https://github.com/cucumber/cucumber/blob/master/lib/cucumber/formatter/legacy_api/adapter.rb so that the background object passed to the formatter still has that old API, but we don't need to let that leak into the core's AST.

WDYT @tooky @brasmusson?

[brasmusson]

I think avoiding circular references is the right thing to do, I only made the fix this way because the attr_accessor :feature declaration indicated the the intention was for backgrounds to know their feature.

[aslakhellesoy]

@brasmusson @mattwynne whatever you do - please keep in mind cucumber-attic/gherkin#12

[brasmusson]

Let's fix this in the Cucumber::Formatter::LegacyApi instead.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.