Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_filtered_backtrace method to unknown result #107

Merged
merged 1 commit into from
Jul 2, 2016

Conversation

danascheider
Copy link
Contributor

This pull request adds a #with_filtered_backtrace method to Result::Unknown, enabling Cucumber to handle empty scenarios more gracefully. Addresses this issue in Cucumber-Ruby: cucumber/cucumber-ruby#967

@danascheider
Copy link
Contributor Author

@mattwynne @dg-ratiodata I'm pretty sure this initial Travis build failed because of a hiccup in the Travis environment - I ran the tests locally using that JRuby version and it passed, then it passed when I re-ran the Travis build.

@ghost
Copy link

ghost commented May 19, 2016

@danascheider Sorry to say, but I think I cannot help that much here. I think, it makes more sense to include @brasmusson and/or @tooky.

I'm more in the role of a contributor for cucumber/cucumber-ruby-core, not maintainer. Not deeply involved into the cucumber (ruby) stuff. But I try to help out with things on a higher level - documentation etc.

@danascheider
Copy link
Contributor Author

Ah gotcha. Well thanks anyway.

@mattwynne mattwynne merged commit d3a6325 into master Jul 2, 2016
mattwynne added a commit that referenced this pull request Jul 2, 2016
CyrilPatrice pushed a commit to PagesjaunesMobile/cucumber-ruby-core that referenced this pull request Feb 1, 2017
@danascheider danascheider deleted the add-with_filtered_backtrace-to-unknown-result branch May 26, 2018 01:12
@lock
Copy link

lock bot commented May 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants