Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement equality for test cases #111

Merged
merged 2 commits into from
Jul 30, 2016
Merged

Conversation

mattwynne
Copy link
Member

This will help finish off the retry feature on the UI

Looks like RSpec uses instance equivalence not object equality when
matching on a stubbed method handler.
@danascheider danascheider merged commit 97bf84a into master Jul 30, 2016
@danascheider danascheider deleted the equality-for-test-cases branch July 30, 2016 16:40
@mattwynne
Copy link
Member Author

Thanks for merging @danascheider, I like it when I don't have to merge my own 'cause I know at least one other person has read the code 👍

@danascheider
Copy link
Contributor

Same! It just always feels weird to merge your own PR.

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants